Skip to content

Add default styles and discussion on style customization #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 12, 2019
Merged

Add default styles and discussion on style customization #44

merged 2 commits into from
Jul 12, 2019

Conversation

@domenic
Copy link
Collaborator

@domenic domenic commented Jul 12, 2019

No description provided.

@domenic domenic requested a review from jackbsteinberg July 12, 2019 20:40
jackbsteinberg
jackbsteinberg reviewed Jul 12, 2019
View reviewed changes
README.md
offset-block-end: 0;
offset-inline-end: 0;
border: solid;
padding: 1em;
Copy link
Owner

@jackbsteinberg jackbsteinberg Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add margin: 1em here? Every library in the study group had their default toast slightly offset from the edge of the screen.
Copy link
Collaborator Author

@domenic domenic Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unsure. I'll change the position to add a 1em offset.
README.md
(Note: we could offer an alternate syntax of `std-toast::part(action) { ... }`.
Discuss in [#20](https://github.com/jackbsteinberg/std-toast/issues/20).)

TODO: link to demos.
Copy link
Owner

@jackbsteinberg jackbsteinberg Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demos will be hosted here (https://jackbsteinberg.github.io/std-toast/) after review, depending on the review timeline we should maybe just add this in
Copy link
Collaborator Author

@domenic domenic Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add in the link as part of #45.
@domenic domenic force-pushed the default-style-updates branch from e6412b1 to 49149fe Compare July 12, 2019 21:47
@domenic domenic merged commit de0ee47 into master Jul 12, 2019
@domenic domenic deleted the default-style-updates branch July 12, 2019 21:47
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jul 15, 2019
Merged
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 15, 2019
@chromium-wpt-export-bot
Set toast default styling
eb3f982 
Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 15, 2019
@chromium-wpt-export-bot
Set toast default styling
cd13f13 
Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 15, 2019
@chromium-wpt-export-bot
Set toast default styling
d5d8bea 
Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 16, 2019
Set toast default styling
f0e02fd 
Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678032}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 16, 2019
@chromium-wpt-export-bot
Set toast default styling
e8f54bd 
Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678032}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 17, 2019
@chromium-wpt-export-bot
Set toast default styling
b4b6c58 
Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678032}
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 24, 2019
@jgraham
Bug 1566163 [wpt PR 17840] - Set toast default styling, a=testonly
a0feb63 
Automatic update from web-platform-tests Set toast default styling Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678032} -- wpt-commits: b4b6c5833f861786f90629463aa7b98382cb2ff7 wpt-pr: 17840
xeonchen pushed a commit to xeonchen/gecko that referenced this pull request Jul 25, 2019
@jgraham
Bug 1566163 [wpt PR 17840] - Set toast default styling, a=testonly
bcff6a3 
Automatic update from web-platform-tests Set toast default styling Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678032} -- wpt-commits: b4b6c5833f861786f90629463aa7b98382cb2ff7 wpt-pr: 17840
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
@natechapin
Set toast default styling
05b0400 
Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678032}
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1566163 [wpt PR 17840] - Set toast default styling, a=testonly
40b2093 
Automatic update from web-platform-tests Set toast default styling Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124 Reviewed-by: Kent Tamura <tkentchromium.org> Commit-Queue: Jack Steinberg <jacksteinbergchromium.org> Cr-Commit-Position: refs/heads/master{#678032} -- wpt-commits: b4b6c5833f861786f90629463aa7b98382cb2ff7 wpt-pr: 17840 UltraBlame original commit: 7687681ce93303981a534c7284f0cbc96c2e9f25
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
@marco-c
Bug 1566163 [wpt PR 17840] - Set toast default styling, a=testonly
d32cb9b 
Automatic update from web-platform-tests Set toast default styling Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124 Reviewed-by: Kent Tamura <tkentchromium.org> Commit-Queue: Jack Steinberg <jacksteinbergchromium.org> Cr-Commit-Position: refs/heads/master{#678032} -- wpt-commits: b4b6c5833f861786f90629463aa7b98382cb2ff7 wpt-pr: 17840 UltraBlame original commit: 7687681ce93303981a534c7284f0cbc96c2e9f25
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1566163 [wpt PR 17840] - Set toast default styling, a=testonly
b860dec 
Automatic update from web-platform-tests Set toast default styling Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124 Reviewed-by: Kent Tamura <tkentchromium.org> Commit-Queue: Jack Steinberg <jacksteinbergchromium.org> Cr-Commit-Position: refs/heads/master{#678032} -- wpt-commits: b4b6c5833f861786f90629463aa7b98382cb2ff7 wpt-pr: 17840 UltraBlame original commit: 7687681ce93303981a534c7284f0cbc96c2e9f25
bhearsum pushed a commit to mozilla-releng/staging-firefox that referenced this pull request May 1, 2025
@jgraham
Bug 1566163 [wpt PR 17840] - Set toast default styling, a=testonly
577cb20 
Automatic update from web-platform-tests Set toast default styling Updated the styling to reflect the changes to the explainer in PR jackbsteinberg/std-toast#44 BUG=972945 Change-Id: I5e89886712b2b5704555352c4f25fe2348441e11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702124 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Jack Steinberg <jacksteinberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#678032} -- wpt-commits: b4b6c5833f861786f90629463aa7b98382cb2ff7 wpt-pr: 17840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@domenic @jackbsteinberg