- Notifications
You must be signed in to change notification settings - Fork 2.8k
[Isaac Sim 6.0] Adds albedo annotator for faster diffuse albedo / depth rendering #4158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Isaac Sim 6.0] Adds albedo annotator for faster diffuse albedo / depth rendering #4158
Conversation
Greptile OverviewGreptile SummaryThis PR introduces a new
Confidence Score: 5/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram participant User participant Camera/TiledCamera participant carb_settings participant rep.AnnotatorRegistry participant SimulationContext User->>Camera/TiledCamera: __init__(cfg with albedo) Camera/TiledCamera->>Camera/TiledCamera: get_version() alt Isaac Sim >= 6.0 Camera/TiledCamera->>Camera/TiledCamera: Check if all data_types in fast_types alt Only albedo/depth types Camera/TiledCamera->>carb_settings: set("/rtx/sdg/force/disableColorRender", True) end Camera/TiledCamera->>SimulationContext: has_gui() alt GUI enabled Camera/TiledCamera->>carb_settings: set("/rtx/sdg/force/disableColorRender", False) end else Isaac Sim < 6.0 Camera/TiledCamera->>Camera/TiledCamera: Log warning (albedo not supported) end Note over Camera/TiledCamera: During _initialize_impl Camera/TiledCamera->>rep.AnnotatorRegistry: register_annotator_from_aov("DiffuseAlbedoSD") Camera/TiledCamera->>rep.AnnotatorRegistry: get_annotator("DiffuseAlbedoSD") Note over Camera/TiledCamera: During _update_buffers_impl Camera/TiledCamera->>rep.AnnotatorRegistry: get_data() Camera/TiledCamera->>User: Return albedo data (4 channels, uint8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
source/isaaclab_tasks/isaaclab_tasks/direct/cartpole/cartpole_camera_env.py, line 113-116 (link)style: Type hints should include
CartpoleAlbedoCameraEnvCfgfor consistency with the new config class.
8 files reviewed, 1 comment
Signed-off-by: Kelly Guo <kellyguo123@hotmail.com>
…c into new_annotators
3e16468 into isaac-sim:feature/isaacsim-6-0
Description
Adapted from #4066 by @matthewtrepte
Introduces new
albedoannotator type for Camera and TiledCamera for faster rendering. The faster path will be enabled if only albedo and/or depth/distance_from_camera/distance_from_image_plane annotators are requested. If regular RGB is also requested, we cannot enable the most performant path.Type of change
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there