anthony-bruscantini #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
f3r reviewed Aug 29, 2017
| // Find the maximum | ||
| function maxOfTwoNumbers (first, second) { | ||
| | ||
| if (first > second) return first; |
There was a problem hiding this comment.
Good job!!
Also, you could consider this:
return (first > second ? first : second); 
ericksicard added a commit to ericksicard/Ironhack-lab-javascript-functions-and-arrays that referenced this pull request Oct 29, 2019
ericksicard added a commit to ericksicard/Ironhack-lab-javascript-functions-and-arrays that referenced this pull request Oct 29, 2019
javivarelakdi pushed a commit to javivarelakdi/lab-javascript-functions-and-arrays that referenced this pull request Dec 27, 2019
jaimemorav added a commit to jaimemorav/lab-javascript-functions-and-arrays that referenced this pull request Jan 6, 2020
jaimemorav added a commit to jaimemorav/lab-javascript-functions-and-arrays that referenced this pull request Jan 6, 2020
caioandreolli added a commit to caioandreolli/lab-javascript-functions-and-arrays that referenced this pull request Jan 25, 2020
fabioMatosCosta added a commit to fabioMatosCosta/lab-javascript-functions-and-arrays that referenced this pull request Feb 19, 2020
GabrielBohn99 added a commit to GabrielBohn99/lab-javascript-functions-and-arrays that referenced this pull request Feb 21, 2020
Closed
JohannaXX added a commit to JohannaXX/lab-javascript-functions-and-arrays that referenced this pull request May 3, 2020
Pumpelgit added a commit to Pumpelgit/lab-javascript-functions-and-arrays that referenced this pull request May 4, 2020
Pumpelgit added a commit to Pumpelgit/lab-javascript-functions-and-arrays that referenced this pull request May 4, 2020
Pumpelgit added a commit to Pumpelgit/lab-javascript-functions-and-arrays that referenced this pull request May 5, 2020
AmanoLX added a commit to AmanoLX/lab-javascript-functions-and-arrays that referenced this pull request Jun 6, 2020
giladt added a commit to giladt/lab-javascript-functions-and-arrays that referenced this pull request Aug 11, 2020
giladt added a commit to giladt/lab-javascript-functions-and-arrays that referenced this pull request Aug 11, 2020
hterayama added a commit to hterayama/lab-javascript-functions-and-arrays that referenced this pull request Oct 30, 2020
luisga32 added a commit to luisga32/lab-javascript-functions-and-arrays that referenced this pull request Nov 20, 2020
Praa199 added a commit to Praa199/lab-javascript-functions-and-arrays that referenced this pull request Jan 13, 2021
Praa199 added a commit to Praa199/lab-javascript-functions-and-arrays that referenced this pull request Jan 13, 2021
…f the Iterations. Up till this point have been commited: ironhack-labs#1, ironhack-labs#2, ironhack-labs#3, ironhack-labs#4 lvl1 & ironhack-labs#4 lvl 2
John-v77 added a commit to John-v77/lab-javascript-functions-and-arrays that referenced this pull request Jan 14, 2021
leoopardo added a commit to leoopardo/lab-javascript-functions-and-arrays that referenced this pull request Mar 22, 2022
leoopardo added a commit to leoopardo/lab-javascript-functions-and-arrays that referenced this pull request Mar 23, 2022
Closed
wijaman23 pushed a commit to wijaman23/lab-javascript-functions-and-arrays that referenced this pull request Apr 30, 2022
AlmuVera added a commit to AlmuVera/lab-javascript-functions-and-arrays that referenced this pull request May 2, 2022
LuisEUM added a commit to LuisEUM/lab-javascript-functions-and-arrays that referenced this pull request May 3, 2022
LuisEUM added a commit to LuisEUM/lab-javascript-functions-and-arrays that referenced this pull request May 3, 2022
elorenn added a commit to elorenn/lab-javascript-functions-and-arrays that referenced this pull request Jun 9, 2022
renatainojosa added a commit to renatainojosa/lab-javascript-functions-and-arrays that referenced this pull request Jun 22, 2022
renatainojosa added a commit to renatainojosa/lab-javascript-functions-and-arrays that referenced this pull request Jun 22, 2022
droidsam1 added a commit to droidsam1/lab-javascript-functions-and-arrays that referenced this pull request Jun 26, 2022
droidsam1 added a commit to droidsam1/lab-javascript-functions-and-arrays that referenced this pull request Jun 26, 2022
droidsam1 added a commit to droidsam1/lab-javascript-functions-and-arrays that referenced this pull request Jun 26, 2022
superpensando added a commit to superpensando/lab-javascript-functions-and-arrays that referenced this pull request Jun 28, 2022
asantamar87 added a commit to asantamar87/lab-javascript-functions-and-arrays that referenced this pull request Nov 16, 2022
physiodevapp added a commit to physiodevapp/lab-javascript-functions-and-arrays that referenced this pull request Nov 16, 2022
fraulueneburg-ironhack added a commit to fraulueneburg-ironhack/lab-javascript-functions-and-arrays that referenced this pull request Feb 12, 2023
KseniiaErnest added a commit to KseniiaErnest/lab-javascript-functions-and-arrays that referenced this pull request Mar 20, 2023
…ed and added explanation.
KseniiaErnest added a commit to KseniiaErnest/lab-javascript-functions-and-arrays that referenced this pull request Mar 21, 2023
gunnar-miklis added a commit to gunnar-miklis/lab-javascript-functions-and-arrays that referenced this pull request Mar 23, 2023
gunnar-miklis added a commit to gunnar-miklis/lab-javascript-functions-and-arrays that referenced this pull request Mar 23, 2023
Closed
ProgrammingDj added a commit to ProgrammingDj/lab-javascript-functions-and-arrays that referenced this pull request May 11, 2023
AlfG71 added a commit to AlfG71/lab-javascript-functions-and-arrays that referenced this pull request Aug 31, 2023
AlfG71 added a commit to AlfG71/lab-javascript-functions-and-arrays that referenced this pull request Aug 31, 2023
SunSunny1210 added a commit to SunSunny1210/lab-javascript-functions-and-arrays that referenced this pull request Feb 17, 2025
SunSunny1210 added a commit to SunSunny1210/lab-javascript-functions-and-arrays that referenced this pull request Feb 17, 2025
SunSunny1210 added a commit to SunSunny1210/lab-javascript-functions-and-arrays that referenced this pull request Feb 17, 2025
SunSunny1210 added a commit to SunSunny1210/lab-javascript-functions-and-arrays that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.