Paris - Mathieu #80
Closed
Paris - Mathieu #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
posva reviewed Jun 30, 2017
| <nav> | ||
| | ||
| <div id = navBar> | ||
| <img src = "images/logo.png" alt = "no picture"> |
There was a problem hiding this comment.
don't forget to indent correctly to make your code more readable
| | ||
| <div id = menu> | ||
| <span id = menuText>Home Tech Games Podcasts Books Bots Developer Tools iMessage Apps</span> | ||
| <img src = "images/arrow-prev.png"alt = "no picture"> |
There was a problem hiding this comment.
we do write `foo = 'foo' in javascript but in html we don't put spaces:
<div id="menu">Also make sure to put double quotes around
And careful about the missing space between alt
| <span>1460</span> | ||
| </div> | ||
| <div> | ||
| <img src = "images/comments.png"alt = "no picture"> |
There was a problem hiding this comment.
you copy pasted the images so many times that you kept missing the space between the src value and the alt attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Skeleton Made, added the missing images, but no time now to start the scss :(
Will style it on Saturday.