Export EOF validation unit tests to json EOFTests #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gumb0 force-pushed the eof/export-validation-tests branch from 2c6214c to 0e863fb Compare gumb0 changed the title 
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@ ## master #818 +/- ## ========================================== - Coverage 97.98% 97.93% -0.05% ========================================== Files 114 116 +2 Lines 11158 11309 +151 ========================================== + Hits 10933 11076 +143 - Misses 225 233 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gumb0 force-pushed the eof/export-validation-tests branch 2 times, most recently from 1548ab2 to 74875e4 Compare 
pdobacz approved these changes Feb 14, 2024
chfast reviewed Feb 14, 2024
test/unittests/eof_validation.cpp Outdated
| namespace | ||
| { | ||
| /// Creates the file path for the exported test based on its name. | ||
| fs::path get_export_test_path(const testing::TestInfo& test_info, std::string_view export_dir) |
Member
There was a problem hiding this comment.
I think it make more sense to share this function with state_transition.cpp. E.g. test_export.cpp?
test/unittests/eof_validation.cpp Outdated
| << hex(test_case.container); | ||
| } | ||
| | ||
| if (const auto export_dir = std::getenv("EVMONE_EXPORT_TESTS"); export_dir != nullptr) |
Member
There was a problem hiding this comment.
This can also be shared by having common abstract ExportableFixture with virtual export_test(...). Can be done later though.
gumb0 force-pushed the eof/export-validation-tests branch from e9f8876 to f918413 Compare 
Member Author
| I think I accidentally removed @chfast's commit |
gumb0 force-pushed the eof/export-validation-tests branch 7 times, most recently from 42a0685 to 2d775e2 Compare 
gumb0 force-pushed the eof/export-validation-tests branch from 2d775e2 to 6d0ae02 Compare chfast reviewed Feb 22, 2024
| # Tests for exporting JSON tests | ||
| | ||
| set(EXPORT_DIR exported_tests) | ||
| set(EXPORT_STATE_TESTS_DIR exported_state_tests) |
Member
There was a problem hiding this comment.
We don't need separate dir any more. The top dir will be the suite name: state_transition and eof_validation. I think it is better to test exporting to the same dir because this is more common use case.
| NAME ${PREFIX}/execute_exported_tests | ||
| # TODO: Broken exported tests are filtered out. | ||
| COMMAND evmone-statetest ${EXPORT_DIR} --gtest_filter=-*block.*:*tx.tx_non_existing_sender | ||
| COMMAND evmone-statetest ${EXPORT_STATE_TESTS_DIR} --gtest_filter=-*block.*:*tx.tx_non_existing_sender |
Member
There was a problem hiding this comment.
This will also export eof_validation suite. You can use it with evmone-eoftest test or filter it out.
gumb0 force-pushed the eof/export-validation-tests branch from 6d0ae02 to 62d18d9 Compare chfast approved these changes Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.