Skip to content

Add project version printing for t8n executable #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rodiazet merged 1 commit into from
Feb 8, 2023
Merged

Add project version printing for t8n executable #555

rodiazet merged 1 commit into from
Feb 8, 2023
+7 −1

Conversation

@rodiazet
Copy link
Member

@rodiazet rodiazet commented Feb 8, 2023

No description provided.

@rodiazet rodiazet requested a review from chfast February 8, 2023 11:30
axic
axic reviewed Feb 8, 2023
View reviewed changes
test/t8n/t8n.cpp Outdated
if (arg == "-v")
{
std::cout << "evmone dev\n"; // FIXME: Return proper version.
std::cout << "evmone " << PROJECT_VERSION << std::endl;
Copy link
Member

@axic axic Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::cout << "evmone " << PROJECT_VERSION << std::endl;
std::cout << "evmone-t8n " << PROJECT_VERSION << std::endl;

Why not?
Copy link
Member Author

@rodiazet rodiazet Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right.
Copy link
Member

@chfast chfast Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends what you want to see in the generated tests.
Copy link
Member Author

@rodiazet rodiazet Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think -t8n is ok. We will probably will have also project versions for other executables so it's good to distinct them
@codecov
Copy link

codecov bot commented Feb 8, 2023 •
edited
Loading

Codecov Report

Merging #555 (7b33ad7) into master (ca7028a) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 7b33ad7 differs from pull request most recent head c6a1624. Consider uploading reports for the commit c6a1624 to get more accurate results

Additional details and impacted files 
@@ Coverage Diff @@ ## master #555 +/- ## ========================================== + Coverage 97.00% 97.01% +0.01%  ========================================== Files 66 64 -2 Lines 6134 6122 -12 ========================================== - Hits 5950 5939 -11  + Misses 184 183 -1
Flag Coverage Δ
blockchaintests 76.96% <ø> (ø)
statetests 71.49% <ø> (-0.04%) ⬇️
unittests 92.74% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/statetest/statetest_runner.cpp 94.11% <0.00%> (-5.89%) ⬇️
test/statetest/statetest_logs_hash.cpp
test/unittests/statetest_logs_hash_test.cpp
lib/evmone/instructions.hpp 100.00% <0.00%> (+0.20%) ⬆️
lib/evmone/advanced_analysis.hpp 100.00% <0.00%> (+2.94%) ⬆️
@rodiazet rodiazet force-pushed the t8n-project-version branch from 94c60e1 to d78e87d Compare February 8, 2023 11:41
chfast
chfast requested changes Feb 8, 2023
View reviewed changes
test/t8n/t8n.cpp Outdated
if (arg == "-v")
{
std::cout << "evmone dev\n"; // FIXME: Return proper version.
std::cout << "evmone-t8n " << PROJECT_VERSION << std::endl;
Copy link
Member

@chfast chfast Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::cout << "evmone-t8n " << PROJECT_VERSION << std::endl;
std::cout << "evmone-t8n " PROJECT_VERSION "\n";
Copy link
Member Author

@rodiazet rodiazet Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it better?
Copy link
Member

@chfast chfast Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The string will be concatenated by the compiler and std::cout called only once.
Copy link
Member Author

@rodiazet rodiazet Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
@rodiazet rodiazet force-pushed the t8n-project-version branch from d78e87d to 7b33ad7 Compare February 8, 2023 12:46
@rodiazet rodiazet force-pushed the t8n-project-version branch from 7b33ad7 to c6a1624 Compare February 8, 2023 13:04
@rodiazet rodiazet merged commit 4ac0ec0 into master Feb 8, 2023
@rodiazet rodiazet deleted the t8n-project-version branch February 8, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@rodiazet @axic @chfast