Skip to content

Conversation

@pdobacz
Copy link
Member

@pdobacz pdobacz commented Oct 29, 2025

This showed up as dead code (from PoV of EEST, of course) and was a couple of regex' away, for reference more or less like variants of:

pre\.insert\(([^,]*),([^;]*\n[^;]*\n[^;]*)\);

replace with

pre[$1] = $2;
@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.77%. Comparing base (fd3bf17) to head (0513e31).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #1352 +/- ## ========================================== - Coverage 84.80% 84.77% -0.03%  ========================================== Files 169 169 Lines 20377 20345 -32 Branches 4126 4126 ========================================== - Hits 17280 17248 -32  Misses 445 445 Partials 2652 2652 
Flag Coverage Δ
eest-develop 80.52% <ø> (+0.02%) ⬆️
eest-develop-gmp 14.70% <0.00%> (+0.02%) ⬆️
eest-legacy 10.28% <0.00%> (+0.01%) ⬆️
eest-legacy-silkpre 16.25% <0.00%> (+0.02%) ⬆️
evmone-unittests 81.18% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 92.87% <ø> (-0.01%) ⬇️
tooling 83.76% <ø> (ø)
tests 81.38% <100.00%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
test/state/test_state.hpp 100.00% <ø> (ø)
test/unittests/eof_example_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_system_call_test.cpp 44.92% <100.00%> (ø)
test/unittests/state_transition.cpp 71.83% <100.00%> (ø)
test/unittests/state_transition_block_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_transition_create_test.cpp 99.50% <100.00%> (-0.01%) ⬇️
test/unittests/state_transition_eip663_test.cpp 100.00% <100.00%> (ø)
test/unittests/state_transition_eof_calls_test.cpp 100.00% <100.00%> (ø)
...est/unittests/state_transition_eof_create_test.cpp 98.88% <100.00%> (ø)
test/unittests/state_transition_extcode_test.cpp 100.00% <100.00%> (ø)
... and 6 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@pdobacz pdobacz requested a review from chfast October 29, 2025 09:03
@chfast
Copy link
Member

chfast commented Oct 29, 2025

I will actually remove some of these files along the EOF implementation :(

@chfast chfast merged commit 326314f into master Oct 29, 2025
23 checks passed
@chfast chfast deleted the test-state-deprecation branch October 29, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants