build: Upgrade compiler settings and disable -Werror #1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Upgrade Cable Compler Settings to 1.2.0 what disables setting "warning as error" (`-Werror`) by default. This is helpful for users and packaging. The CI still enables "warning as error" with CMake standardized `-DCMAKE_COMPILE_WARNING_AS_ERROR=TRUE`.
Open
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## master #1351 +/- ## ======================================= Coverage 84.80% 84.80% ======================================= Files 169 169 Lines 20377 20377 Branches 4126 4126 ======================================= Hits 17280 17280 Misses 445 445 Partials 2652 2652
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Upgrade Cable Compler Settings to 1.2.0 what disables setting "warning as error" (
-Werror) by default. This is helpful for users and packaging. The CI still enables "warning as error" with CMake standardized-DCMAKE_COMPILE_WARNING_AS_ERROR=TRUE.