Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Sep 22, 2025

In the coverage report for EEST include only core implementation files.
In the CI script allow specifying what files to ignore in the report.

The EEST coverage report from this PR:
https://output.circle-artifacts.com/output/job/82618ef1-7278-4e0a-b562-c917b75bf66b/artifacts/0/coverage/html/index.html

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.04%. Comparing base (4507489) to head (1bdef0b).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #1318 +/- ## ========================================== - Coverage 87.21% 87.04% -0.17%  ========================================== Files 167 167 Lines 24728 24728 Branches 4064 4064 ========================================== - Hits 21566 21525 -41  - Misses 522 547 +25  - Partials 2640 2656 +16 
Flag Coverage Δ
eest-develop 83.99% <ø> (+60.72%) ⬆️
eest-develop-gmp 15.90% <ø> (ø)
eest-legacy 11.13% <ø> (ø)
eest-legacy-silkpre 17.66% <ø> (ø)
evmone-unittests 83.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 93.52% <ø> (ø)
tooling 86.19% <ø> (-2.17%) ⬇️
tests 84.12% <ø> (ø)
see 5 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chfast chfast force-pushed the ci/coverage_eest branch 6 times, most recently from 859dcd2 to 7322011 Compare September 22, 2025 20:25
@chfast chfast marked this pull request as ready for review September 22, 2025 20:37
@chfast chfast requested a review from pdobacz September 22, 2025 20:37
@chfast
Copy link
Member Author

chfast commented Sep 23, 2025

The overall coverage is lower because we excluded some files. We should bring this coverage back as a part of some other report but this is for some other days.

Copy link
Member

@pdobacz pdobacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've eyeballed the report and I think it makes sense

In the coverage report for EEST include only core implementation files. In the CI script allow specifying what files to ignore in the report.
@chfast chfast merged commit 6586b45 into master Sep 26, 2025
19 of 21 checks passed
@chfast chfast deleted the ci/coverage_eest branch September 26, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants