Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Aug 29, 2025

Reduce the scalar by the curve group order.
This allows using more efficient add algorithm in the loop because doubling cannot happen.

@codecov
Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.14%. Comparing base (9aa68c4) to head (06b545c).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/evmone_precompiles/ecc.hpp 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #1305 +/- ## ========================================== - Coverage 87.15% 87.14% -0.01%  ========================================== Files 167 167 Lines 24732 24739 +7 Branches 4059 4061 +2 ========================================== + Hits 21554 21560 +6  Misses 537 537 - Partials 2641 2642 +1 
Flag Coverage Δ
eest-develop 17.79% <42.85%> (+<0.01%) ⬆️
eest-develop-gmp 15.82% <42.85%> (+<0.01%) ⬆️
eest-fusaka 12.17% <0.00%> (-0.01%) ⬇️
eest-legacy 11.06% <0.00%> (-0.01%) ⬇️
eest-legacy-silkpre 17.68% <71.42%> (+0.01%) ⬆️
eest-static 18.71% <71.42%> (+0.01%) ⬆️
evmone-unittests 83.75% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core 93.28% <85.71%> (-0.01%) ⬇️
tooling 88.35% <ø> (ø)
tests 84.12% <ø> (ø)
Files with missing lines Coverage Δ
lib/evmone_precompiles/ecc.hpp 98.26% <85.71%> (-0.40%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chfast chfast merged commit 9ce7bfa into master Aug 29, 2025
23 of 24 checks passed
@chfast chfast deleted the ecc_mul_order branch August 29, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants