Modify blob base fee calculation for Osaka (EIP-7918) #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #1281 +/- ## ======================================= Coverage 87.14% 87.14% ======================================= Files 166 166 Lines 24622 24633 +11 Branches 4054 4055 +1 ======================================= + Hits 21456 21467 +11 Misses 532 532 Partials 2634 2634
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
chfast force-pushed the osaka/eip7918_blob_base_fee branch 2 times, most recently from 44c0e2e to b29380b Compare chfast changed the title 
chfast force-pushed the osaka/eip7918_blob_base_fee branch from b29380b to 20dbfc8 Compare There was a problem hiding this comment.
Pull Request Overview
This PR implements EIP-7918 to modify blob base fee calculation for the Osaka fork. The change introduces a new mechanism for calculating excess blob gas that considers the relationship between blob base cost and transaction fees.
- Updates
calc_excess_blob_gasfunction to include parent base fee and blob base fee parameters - Implements Osaka-specific logic that adjusts excess blob gas calculation when blob base cost exceeds a threshold
- Updates test cases and CI configuration to accommodate the new blob fee calculation
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/state/block.hpp | Updates function signature to include parent base fee and blob base fee parameters |
| test/state/block.cpp | Implements EIP-7918 logic with Osaka-specific blob gas calculation |
| test/statetest/statetest_loader.cpp | Updates test loader to pass additional parameters for new calculation |
| test/unittests/statetest_loader_block_info_test.cpp | Adds parent base fee field to test data |
| test/blockchaintest/blockchaintest_runner.cpp | Updates blockchain test runner to use new function signature |
| circle.yml | Removes test filter that was excluding EIP-7918 tests |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This implements EIP-7918.