Skip to content

Conversation

@chfast
Copy link
Member

@chfast chfast commented Mar 14, 2025

Another -10% time reduction.

@chfast chfast added the precompiles Related to EVM precompiles label Mar 14, 2025
@codecov
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (ad6e906) to head (4f394a0).
Report is 1 commits behind head on master.

Additional details and impacted files
@@ Coverage Diff @@ ## master #1170 +/- ## ========================================== + Coverage 94.79% 94.80% +0.01%  ========================================== Files 172 172 Lines 19537 19580 +43 ========================================== + Hits 18520 18563 +43  Misses 1017 1017 
Flag Coverage Δ
eest_gmp 15.36% <0.00%> (-0.04%) ⬇️
eof_execution_spec_tests 2.55% <0.00%> (-0.01%) ⬇️
ethereum_tests 21.20% <95.74%> (+0.15%) ⬆️
ethereum_tests_silkpre 18.39% <95.65%> (+0.18%) ⬆️
execution_spec_tests 18.18% <0.00%> (-0.05%) ⬇️
unittests 92.54% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/evmone_precompiles/bn254.cpp 100.00% <100.00%> (ø)
lib/evmone_precompiles/ecc.hpp 100.00% <100.00%> (ø)
lib/evmone_precompiles/secp256k1.cpp 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@chfast chfast force-pushed the precompiles/ecmul branch from 142b394 to 251f993 Compare April 17, 2025 20:34
@chfast chfast marked this pull request as ready for review April 17, 2025 20:36
@chfast chfast requested a review from rodiazet April 17, 2025 20:36
Copy link
Member

@rodiazet rodiazet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@chfast chfast force-pushed the precompiles/ecmul branch from 251f993 to 4f394a0 Compare April 24, 2025 09:45
@chfast chfast enabled auto-merge (squash) April 24, 2025 09:49
@chfast chfast merged commit 17fe4a4 into master Apr 24, 2025
24 checks passed
@chfast chfast deleted the precompiles/ecmul branch April 24, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

precompiles Related to EVM precompiles

3 participants