Change EOFCREATE new address hashing scheme #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
gumb0 force-pushed the eof/compute-eofcreate-address branch 2 times, most recently from bcacbde to 68a8ff7 Compare 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## master #1140 +/- ## ========================================== - Coverage 94.48% 94.47% -0.01% ========================================== Files 170 170 Lines 18020 18024 +4 ========================================== + Hits 17027 17029 +2 - Misses 993 995 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
gumb0 force-pushed the eof/compute-eofcreate-address branch from 68a8ff7 to be436a5 Compare 
pdobacz reviewed Feb 25, 2025
Member
pdobacz left a comment
pdobacz left a comment There was a problem hiding this comment.
this should also remove hashing cost from lib/evmone/instructions_calls.cpp:408
gumb0 force-pushed the eof/compute-eofcreate-address branch from be436a5 to 1056b16 Compare 5 tasks
pdobacz approved these changes Mar 17, 2025
gumb0 force-pushed the eof/compute-eofcreate-address branch 2 times, most recently from fbe305e to 5a49ebe Compare 
gumb0 force-pushed the eof/compute-eofcreate-address branch from 5a49ebe to 13dfa85 Compare gumb0 force-pushed the eof/compute-eofcreate-address branch from 4e44584 to 8958936 Compare pdobacz approved these changes Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implement ethereum/EIPs#9298