Skip to content

Conversation

odisseus
Copy link
Contributor

@odisseus odisseus commented Jun 3, 2020

No description provided.

@odisseus odisseus marked this pull request as draft June 3, 2020 03:52
@odisseus odisseus force-pushed the latest-multiaddr branch 2 times, most recently from 8958bc6 to 14fd9e7 Compare June 3, 2020 04:08
@odisseus odisseus changed the title Use the latest master commit of java-multiaddr. Use the fresh versions of dependencies Jun 3, 2020
@odisseus odisseus force-pushed the latest-multiaddr branch from 23ede65 to 14fd9e7 Compare June 3, 2020 05:35
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@odisseus I think method names changed:

https://travis-ci.com/github/ipfs-shipyard/java-ipfs-http-client/jobs/342996278#L1291

Will you have bandwidth to take a look and update this PR with test fixes?

@lidel lidel mentioned this pull request Jun 16, 2020
3 tasks
@odisseus
Copy link
Contributor Author

It turned out that the issues with this set of projects run much deeper than a simple method rename. I decided to solve them bottom up, because I need an up-to-date IPFS interface for the project I'm working at, and i don't feel like linking the entirety of Peergos just for that purpose. Eventually I will get to fix this particular problem as well.

@odisseus
Copy link
Contributor Author

If by "method names changed" you mean the java.lang.NoSuchMethodError thrown by many test cases, then what's actually changed is the signature of Multihash.deserialize. The latest version of java-cid still expects the old signature, and this causes the errors. They should go away if ipld/java-cid#13 gets merged.

@autonome
Copy link

Hi @odisseus are you still working on this or can I have others pick it up? Or is it blocked?

 java-multiaddr to commit 2347e9ff1b java-cid to release v1.1.1 java-multihash to commit 0eb305c02c
@odisseus
Copy link
Contributor Author

odisseus commented Jul 26, 2020

I stopped working on my pull requests to this library and its dependencies, because I'm not sure my work has any chance to get into the master branch. I believe this particular set of changes can be merged right away; however, it will solve just some of the problems, not all of them.

In particular, the libraries java-multihash and java-cid need to be updated to use a recent commit of java-multibase (ad627a0872 or later), because that commit fixes a critical bug which is inherited by all the dependent libraries. After that's done, the dependency versions in this POM file will have to be updated again.

@lidel
Copy link
Member

lidel commented Jul 28, 2020

@odisseus fyi there are open bounties for fixing java-ipfs-http-client library now (#157 (comment)) and we definitely are up for accepting fixes.

If you want to invest time and claim the bounty, please comment in #157 (comment) and provide us with list of all PRs that you are blocked on (Java libs are not actively maintained, but me and @autonome can do some poking/spelunking to unblock you)

@lidel
Copy link
Member

lidel commented Jul 29, 2020

Superseded by #170

@lidel lidel closed this Jul 29, 2020
@lidel lidel mentioned this pull request Jul 31, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants