fix(angular): prevent invalid import recommendations #1815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sean-perkins requested review from liamdebeasi and removed request for a team 
liamdebeasi approved these changes Nov 7, 2023
There was a problem hiding this comment.
I was wondering if we should be placing this in tsconfig.json instead for other IDEs, but sounds like this is a VSCode-specific feature for now: microsoft/TypeScript#49578 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR updates the module and starter templates for Angular to ship with a default VSCode setting that prevents importing from invalid locations.
For example, the base projects using modules will ignore import recommendations from
@ionic/angular/standaloneand@ionic/angular/common. Standalone projects will ignore import recommendations from@ionic/angularand@ionic/angular/common.