Add padding to .placeholder-icon #672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently there is no gap between the `.placeholder-icon` and the placeholder text, sometimes its fixed by using an ` `, I think add padding is a better solution. I hope I did the sass selector correctly, you may check it twice.
adamdbradley added a commit that referenced this pull request Feb 25, 2014
Add padding to .placeholder-icon
Contributor
| Cool thanks |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently there is no gap between the
.placeholder-iconand the placeholder text (see this in action here http://ionicframework.com/docs/components/#input-icons), sometimes its fixed by someone using which is just a bad workaround, I think adding padding is a better solution.I hope I did the sass selector correctly, you may check it twice.