Skip to content

docs(tabs): add playground for basic usage #3824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 13, 2024
Merged

docs(tabs): add playground for basic usage #3824

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1d63cef
docs(tabs): add playground for basic usage
thetaPC Sep 11, 2024
c203487
docs(tabs): add warning for required tabbar
thetaPC Sep 12, 2024
4781f9d
docs(tab): update note
thetaPC Sep 12, 2024
7d41c81
docs(tabs): remove warning
thetaPC Sep 12, 2024
3fe3f93
docs(tab): update note on when to use
thetaPC Sep 13, 2024
ce6783c
docs(tabs): add dark mode to vue router
thetaPC Sep 13, 2024
bd732de
docs(tabs): use correct syntax
thetaPC Sep 13, 2024
109e036
docs(tabs): remove ion content
thetaPC Sep 13, 2024
cfb3567
Update docs/api/tab.md
thetaPC Sep 13, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs(tabs): add warning for required tabbar
  • Loading branch information
@thetaPC
thetaPC committed Sep 12, 2024
commit c2034879179b7f756fe34841f7a70a9dd4a3f49f
4 changes: 4 additions & 0 deletions docs/api/tabs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ The `ion-tabs` component does not have any styling and works as a router outlet

Both `ion-tabs` and `ion-tab-bar` can be used as standalone elements. They don’t depend on each other to work, but they are usually used together in order to implement a tab-based navigation that behaves like a native app.

:::warning
Using `IonTabs` within React requires the `IonTabBar` component as a direct child of `IonTabs`.
:::
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a separate PR that removes the need to include IonTabBar within IonTabs. If that PR is approved first then I'll remove this warning before this docs PR is merged. Else I'll remove it in a separate PR.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to remove this 👍

The `ion-tab-bar` needs a slot defined in order to be projected to the right place in an `ion-tabs` component.

## Basic Usage
Expand Down