feat(generators): add module options #2551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2017
imhoffd suggested changes Jul 25, 2017
| switch (type) { | ||
| case 'page': | ||
| await AppScripts.processPageRequest(context, name); | ||
| await AppScripts.processPageRequest(context, name, includeNgModule, includePageConstants); |
There was a problem hiding this comment.
Maybe move the options into an object? I can imagine there being a lot more than 2 options for generators. We probably don't want 10+ positional args, especially cross-library.
| description: 'The name of the component being generated', | ||
| } | ||
| ], | ||
| options: [ |
There was a problem hiding this comment.
You can provide examples of these options using the exampleCommands list above.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Adds
moduleandno-moduleflags to the CLIRequires ionic-team/ionic-app-scripts#1141 to be merged first