This repository was archived by the owner on May 1, 2020. It is now read-only.
Propagate errors from webpack stats #871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Prior to this patch, the script would only raise errors raised directly by webpack and skip errors raised from the compilation. This is contrary to what webpack suggests in terms of error handling[1]. This patch makes it so that any compilation errors will cause ionic to also abort the build, while any compilation warnings will log a warning through ionic's Logger.
This was referenced Apr 17, 2017
Closed
| @danbucholtz this could be useful, what do you think? |
| I'll check this out when I get a chance. Thanks, |
| Hello, |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Prior to this patch, the script would only raise "internal" errors raised by webpack and skip "compilation" errors that could be caused by faulty config or source code. This is contrary
to what webpack suggests in terms of error handling[1].
This patch makes it so that any compilation errors will cause ionic to also abort the build, while any compilation warnings will log a warning through ionic's Logger.
[1] https://webpack.js.org/api/node/#error-handling