This repository was archived by the owner on May 1, 2020. It is now read-only.
fix(build): fix issue that extends
in ts-config.json
property is … #851
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
While typescript support
extends
of another tsconfig, a limitation invalidateRequiredFilesExist
method doesn't as it's reading the file usingfs
, rather thangetTsConfig
which is a wrapper of theTypeScript API
,Changes proposed in this pull request:
getTsConfigAsync
methodvalidateRequiredFilesExist
use it rather thanreadFileAsync
for thetsconfig.json
Note: I cannot run Unit Tests
Fixes: #745