This repository was archived by the owner on May 1, 2020. It is now read-only.
fix(http-server): log error when failing to read getProjectJson. If … #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…he ionic.config.json had an error it was silently failing to setup proxies. ionic-team/ionic-framework#9388
| It looks like this was already taken care of. Thank you for the PR and for contributing to Ionic. Thanks, |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
There was no logging error when
getProjectJson()failed. This issue would have been resolved by this fix. It would have informed this user of an error in their config file if we allowed the error to bubble up.Changes proposed in this pull request:
.thenblock.=>.Fixes: #
Can't migrate the issue but I found this via: ionic-team/ionic-framework#9388