feat(createWorker): pass argv and config_argv to spawned processes

[alan-agius4]

Short description of what this resolves:

In my cleancss.config.js and uglifyjs.config.js, I am dependent on npm args. However the worker-client is being spawned as another process, which is causing the args and npm config argv not to be passed.

Changes proposed in this pull request:

• pass the argv

Fixes: #463

[alan-agius4]

@danbucholtz new PR here.

[danbucholtz]

@alan-agius4,

What is process.env.npm_config_argv here? Couldn't you just pass the process.argv?

Thanks,
Dan

[alan-agius4]

Not really as args flag get 'lost'. Example if i have npm scripts that
calls another one.

Another alternative would be to get the args via
JSON.parse(process.env.npm_config_argv).original and pass them as a
parameter merged with process.args

[alan-agius4]

The alternative would be something like what you are doing here: https://github.com/driftyco/ionic-app-scripts/blob/13d97461c2410f9694ea866e6250d12680c89012/bin/ionic-app-scripts.js

Let me know which one you prefer

[alan-agius4]

@danbucholtz any update please on which is the prefered approach?

[danbucholtz]

I will take a look at this. Sorry, been focused 100% on some AoT changes.

Thanks,
Dan

[danbucholtz]

It's gonna be another week or so. Just giving you a heads up. I am 100% focused on getting what we presently have into a shippable state for a 1.0.0.

Thanks,
Dan

[danbucholtz]

@alan-agius4,

Can you write some tests to validate this? We are putting a bigger focus on unit tests with all new functionality.

Thanks,
Dan

[alan-agius4]

I am currently on vacation, I'll do it once I am back :)

…

On Sat, 17 Dec 2016 at 01:21, Dan Bucholtz ***@***.***> wrote: @alan-agius4 <https://github.com/alan-agius4>, Can you write some tests to validate this? We are putting a bigger focus on unit tests with all new functionality. Thanks, Dan — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#487 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AQv-WtwShWM51CCrJpZYUXwBulmQ6Pz0ks5rIsilgaJpZM4K-m_E> .

[danbucholtz]

Sounds good, no hurry @alan-agius4. We appreciate your help!

Thanks,
Dan

[alan-agius4]

Hi @danbucholtz,

I am trying to test the forked process however, I am finding it a bit hard as they have an easy way to access their argv, is not within an executed scripts. Any tips please?

[danbucholtz]

@alan-agius4,

Not sure 😆 . Mock as much as needed.

Thanks,
Dan