This repository was archived by the owner on May 1, 2020. It is now read-only.
feat: add --ignorets flag to allow building despite TS errors, fixes #443 #471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Sorry, I don't think we want to enable this functionality. Thanks for contributing! Thanks, |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Ionic 2 beta allowed using a parameter to override its default behavior of canceling builds if it could not fully follow all of the typings. Users who did so, myself included, made a lengthy upgrade to RC (having accumulated ~1k TS errors on working code) only to find out this compatibility had been broken, and faced with the prospect of having to convince superiors to go through a 1w+ process of fixing TS errors, which may be hard to phrase as business value toward them. This PR addresses this by enabling a similar override to side-step the immediate problem.
Changes proposed in this pull request:
add a
--ignorets/-iCLI param to allow building despite TS errorsFixes: #443