This repository was archived by the owner on May 1, 2020. It is now read-only.
updating @angular-devkit/build-opitmizer to fix issue #3324 #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @jayordway This issue? ionic-team/ionic-cli#3324 |
| @dwieeb Yes, this has been frustrating many ionic developers who also use firebase & @angular/fire |
| Wow this really fixed the issue. 👍 👍 They should merge this. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Newer versions of firebase-js-sdk will not complete a production build.
Any version after @firebase/database 0.2.1 will freeze with a memory leak during either a iOS or Android production build.
Changes proposed in this pull request:
Updating the package.json to use the latest version of @angular-devkit/build-optimizer,
version 0.6.8 resolves the issue and the --prod flag will work and run the optimizejs flag without hanging.
Fixes: #