This repository was archived by the owner on May 1, 2020. It is now read-only.
Fix for 1132: Component HTML template not updated when saved #1420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
HTML template of components is not updated by ionic serve after saving the file. When a module is shared among multiple modules, e.g., a components module, the component template is present in multiple bundle files, so the template should be replaced in all bundle files.
intodevelopment changed the title 
| May also fix #1491 |
| I think the community would appreciate if somebody could review & merge this PR. This seems to be a problem for a lot of users (including me) |
| ping @dwieeb |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
HTML template of components is not updated by ionic serve after saving the file.
When a module is shared among multiple modules, e.g., a components module, the component template is present in multiple bundle files, so the template should be replaced in all bundle files.
Changes proposed in this pull request:
Instead of only replacing the template in the first matching bundle file, replace it in all matched bundle files. So removing the
breakfixes this.Fixes: #1132