This repository was archived by the owner on May 1, 2020. It is now read-only.
fix(webpack): also check for .json in optimization step #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The optimization step was not looking for the .json file extension, which is default node.js behaviour and so is presumed by libraries like `got`. (`webpack.config.js` already is configured this way)
| Hi @janpio , this is no longer applicable. Thanks for contributing to Ionic! Thanks, |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The optimization step was not looking for the .json file extension, which is default node.js behaviour and so is presumed by libraries like
got. (webpack.config.jsalready is configured this way)closes #1148