Skip to content
This repository was archived by the owner on May 1, 2020. It is now read-only.

Improve perf of lint #1024

Merged
merged 46 commits into from
Jun 30, 2017
Merged

Improve perf of lint #1024

merged 46 commits into from
Jun 30, 2017

Conversation

rolandjitsu
Copy link
Contributor

@rolandjitsu rolandjitsu commented Jun 5, 2017 •
edited
Loading

Short description of what this resolves:

Address the performance of linting. It currently takes around 24s to lint the conference app, but with the latest changes it takes on average 2s.

Changes proposed in this pull request:

  • create a TS program and linter only once per linting instance
  • fetch lint results only after all files have been linted
  • fix lint errors for src
  • fix npm warning (complains about missing peer dep. @angular/animations)
  • bump tslint-eslint-rules to latest (which uses TSLint v5)

Fixes: #

@danbucholtz thanks for pointing out the slowness 👍
rolandjitsu added 30 commits May 2, 2017 18:34
@rolandjitsu
chore: ignore WebStorm config files
759df0c
@rolandjitsu
chore: upgrade internal tslint dependencies
8913bd0 
- update tslint-eslint-rules - run tslint with --type-check flag
@rolandjitsu
fix(interfaces): remove unnecessary semicolons
5d18726
@rolandjitsu
fix: remove unnecessary semicolons
ddf7543
@rolandjitsu
chore: use stylish formatter for tslint
b360f88
@rolandjitsu
fix: fix tslint errors
c0f9d59
@rolandjitsu
chore: update mock-fs (allows using Node v7+)
ca5818b
@rolandjitsu
feat(lint): upgrade to TSLint v5
b537d03
@rolandjitsu
feat(lint): add ENV_TYPE_CHECK_ON_LINT and default to true
132e2b4
@rolandjitsu
test(lint): cleanup a little
4807d69
@rolandjitsu
refactor(lint): improve linting logic
30bb238
@rolandjitsu
fix(lint): make CLI argument the same as the env var
215fd4f
@rolandjitsu
feat(lint): add support for enabling type check during lint
45dc7b3
@rolandjitsu
test(lint): more cleanup
d0bcdc1
@rolandjitsu
fix(lint): set project dir to context {rootDir}
d0971e9
@rolandjitsu
chore: update tslint
2ed8ffe
@rolandjitsu
chore(lint): add typeCheck() fn
ab297f4
@rolandjitsu
Merge branch 'master' of github.com:driftyco/ionic-app-scripts
6260240
@rolandjitsu
chore: fix tslint errors
9c4ebab
@rolandjitsu
feat: implement and run type check if enabled
05b3097
@rolandjitsu
refactor(lint): rename generateFormattedErrorMsg() to generateErrorMe…
b7132a9 
…ssageForFiles()
@rolandjitsu
fix(lint): filter duplicate file names
9074979
@rolandjitsu
docs(lint): update note
dcb8638
@rolandjitsu
chore(lint): add some TODOs
ed4ffab
@rolandjitsu
feat(lint): set default value for --typeCheck to false
59a8703
@rolandjitsu
docs(lint): document --typeCheck flag
1880608
@rolandjitsu
fix(lint): don't create a new instance of BuildError when throwing af…
a9cfe79 
…ter linting failed
@rolandjitsu
fix(lint): set --typeCheckOnLint to null as default instead of false
db27d52
@rolandjitsu
test(lint): fix typeCheckOnLint flag tests
d032fa3
@rolandjitsu
test(lint): add tests for generateErrorMessageForFiles(), getFileName…
9965394 
…s() and removeDuplicateFileNames()
rolandjitsu added 15 commits May 5, 2017 20:10
@rolandjitsu
chore(lint): remove some TODOs
1037ff4
@rolandjitsu
fix(lint): properly pass CLI arguments to linter
649539c
@rolandjitsu
feat(lint): properly disable type check during builds
84c700d
@rolandjitsu
fix(lint): allow null TSLint config file
d3f77d1
@rolandjitsu
chore: revert string change
36163d1
@rolandjitsu
Merge branch 'master' of github.com:driftyco/ionic-app-scripts
e59d753
@rolandjitsu
Merge branch 'master' of github.com:ionic-team/ionic-app-scripts
10e064a
@rolandjitsu
chore: fix npm warning
e550c00
@rolandjitsu
chore: upgrade tslint-eslint-rules
8c347d9
@rolandjitsu
perf(lint): only create the linter and TS program once per linting in…
eb5c7ba 
…stance instead of once per file
@rolandjitsu
chore: fix tslint errors
149c4f5
@rolandjitsu
chore(lint): only fetch lint result after all files have been linted
4dca369 
- rename processLintResults() to processLintResult() - update jsdocs
@rolandjitsu
test(lint): test all lint fns
cb6d37a
@rolandjitsu
chore: fix tslint errors
b24d8ea
@rolandjitsu
refactor(lint): use Set to filter unique file names
a1e603d
@danbucholtz
Copy link
Contributor

Will merge next week. Thanks!!
@danielsogl
Copy link
Contributor

@rolandjitsu Fix the conflicts so we can test the changes.
@danielsogl danielsogl mentioned this pull request Jun 27, 2017
Closed
@rolandjitsu
Copy link
Contributor Author

@danielsogl done 😄
@danbucholtz
Copy link
Contributor

Thanks @rolandjitsu 🎉

Thanks,
Dan
@danbucholtz danbucholtz merged commit 106d82c into ionic-team:master Jun 30, 2017
@adamgalmor
Copy link

adamgalmor commented Jul 2, 2017 •
edited
Loading

I've updated to ionic-app-scripts 1.3.12 and I'm still getting: " lint finished in 322.80 s"

Cordova CLI: 6.5.0
Ionic Framework Version: 3.4.2
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.3.12
OS: Windows 10
Node Version: v6.11.0
@danbucholtz
Copy link
Contributor

danbucholtz commented Jul 3, 2017 •
edited
Loading

@adamgalmor, it's not published yet. I need to do some testing. It'll probably be out Wednesday.

Thanks,
Dan
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants

@rolandjitsu @danbucholtz @danielsogl @adamgalmor