Skip to content

fix(ios): respect KeyboardAppearanceDark preference from webview plugin #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2019
Merged

fix(ios): respect KeyboardAppearanceDark preference from webview plugin #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/ios/CDVIonicKeyboard.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,13 +87,15 @@ - (void)pluginInitialize
}
self.hideFormAccessoryBar = [settings cordovaBoolSettingForKey:@"HideKeyboardFormAccessoryBar" defaultValue:YES];

// get the KeyboardStyle value from config.xml
NSString *keyboardStyle = [settings cordovaSettingForKey:@"KeyboardStyle"];
if (keyboardStyle) {
// call to setKeyboardStyle
[self setKeyboardStyle:keyboardStyle];
}

if ([settings cordovaBoolSettingForKey:@"KeyboardAppearanceDark" defaultValue:NO]) {
[self setKeyboardStyle:@"dark"];
}

NSNotificationCenter *nc = [NSNotificationCenter defaultCenter];

[nc addObserver:self selector:@selector(onKeyboardWillHide:) name:UIKeyboardWillHideNotification object:nil];
Expand Down Expand Up @@ -156,7 +158,6 @@ - (void)onKeyboardWillShow:(NSNotification *)note
[self resetScrollView];
}

// call to setKeyboardStyle in case it's changed
[self setKeyboardStyle:self.keyboardStyle];

NSString *js = [NSString stringWithFormat:@"Keyboard.fireOnShowing(%d);", (int)height];
Expand Down