Add Tanstack Angular Support #166
Conversation
Add Tanstack Query Angular support
| To view this pull requests documentation preview, visit the following URL: docs.page/invertase/tanstack-query-firebase~166 Documentation is deployed and generated using docs.page. |
|
|
| Just tried installing Source code: https://github.com/HassanBahati/tanstack-query-firebase-examples/tree/main/angular/firebase-dataconnect-movies-app Using npm:  Using pnpm: |
| queryKey.set([ref.name, ref.variables]); | ||
| const { data, ...rest } = await executeQuery(ref); | ||
| return { | ||
| ...data, |
There was a problem hiding this comment.
Why are we merging this? If someone has a query with a top-level field called source, fetchTime or ref, that field will be shadowed by the ...rest below and they will not be able to access that field. The typing FlattenedQueryResult above doesn't seem to reflect this behavior accurately either.
Furthermore, based on this comment we may add future metadata fields there. If/when we do so, every new field we add will be a breaking change since it may shadow yet another top-level field.
| export type GeneratedSignature<Data, Variables> = ( | ||
| dc: DataConnect, | ||
| vars: Variables | ||
| ) => MutationRef<Data, Variables>; // TODO(mtewani): Add __angular: true |
| FirebaseError, | ||
| Arguments | ||
| >; | ||
| // TODO(mtewani): Just check for the fact that the user has passed in a generated Angular fn. AKA __angular: true |
6 participants
No description provided.