-
- Notifications
You must be signed in to change notification settings - Fork 377
docs: update v8 docs links to point to legacy site #2227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe documentation file Changes
Assessment against linked issues
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/guide/extra/v8-docs.md (2)
7-20
: Consider automating link verification for the long “Guide” section.All anchors look fine at a glance, but 14 deep links is a lot to keep manually in sync with the legacy site.
A small CI check (e.g.linkinator
,lychee
, or a bashcurl
loop) would prevent silent rot.No change required for this PR—just flagging the maintainability angle.
21-21
: Nit: add trailing slash for directory URL for marginally faster redirects.
https://kazupon.github.io/vue-i18n/api/
avoids the extra 301 compared with.../api
(no slash).
Low-impact but easy win.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/guide/extra/v8-docs.md
(1 hunks)
🔇 Additional comments (1)
docs/guide/extra/v8-docs.md (1)
3-5
: ✅ All top-level links resolve correctlyVerified each URL with a quick curl check—
introduction.html
,started.html
, andinstallation.html
all return HTTP 200. No path adjustments needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much!
fixes #2225
Summary by CodeRabbit