Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Conversation

@LJ-underdog
Copy link
Contributor

Type of Change

feature or bug fix or documentation or others
API changed or not:not
bug fix

Description

  • Adding a bias to Bloom's ffn fusion can inference logical sentences, but it's not the same as modified sentences
    detail description
    JIRA ticket: xxx

Expected Behavior & Potential Risk

the expected behavior that triggered by this PR

How has this PR been tested?

how to reproduce the test (including hardware information)

Dependency Change?

any library dependency introduced or removed

Signed-off-by: intellinjun <jun.lin@intel.com>
Signed-off-by: intellinjun <jun.lin@intel.com>
Signed-off-by: intellinjun <jun.lin@intel.com>
Signed-off-by: intellinjun <jun.lin@intel.com>
Signed-off-by: intellinjun <jun.lin@intel.com>
Signed-off-by: intellinjun <jun.lin@intel.com>
@LJ-underdog
Copy link
Contributor Author

LJ-underdog commented Nov 3, 2023

image
old result

@LJ-underdog
Copy link
Contributor Author

LJ-underdog commented Nov 3, 2023

image

new result

Copy link
Contributor

@yuchengliu1 yuchengliu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LJ-underdog LJ-underdog marked this pull request as ready for review November 3, 2023 07:36
@LJ-underdog LJ-underdog requested a review from airMeng as a code owner November 3, 2023 07:36
Copy link
Contributor

@a32543254 a32543254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VincyZhang VincyZhang merged commit d9b484a into main Nov 3, 2023
@VincyZhang VincyZhang deleted the fix_bloom_ffn_fusion branch November 3, 2023 08:06
@DDEle DDEle added ITREX.cpp and removed WIP labels Nov 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

7 participants