Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Conversation

@Spycsh
Copy link
Contributor

@Spycsh Spycsh commented Sep 11, 2023

Type of Change

hpu hardware enabling

Description

Now ASR/TTS should support HPU/CPU/GPU

Expected Behavior & Potential Risk

Now ASR/TTS should support HPU/CPU/GPU

How has this PR been tested?

Run the two UT on HPU

/intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/tests/audio# python test_asr.py /intel-extension-for-transformers/intel_extension_for_transformers/neural_chat/tests/audio# python test_tts.py 

Dependency Change?

None

@hshen14
Copy link
Contributor

hshen14 commented Sep 12, 2023

@hshen14 without LD_PRELOAD, ipex.cpu.runtime.CPUPool will also not be used anymore in the main code, otherwise it will cause an error that expect that env variable to exist. Please re-check that.

Yes, we don't need ipex.cpu.runtime neither. We can just set the core binding using numactl -m 0 -C cores to get the similar effect.

@Spycsh
Copy link
Contributor Author

Spycsh commented Sep 12, 2023

@hshen14 without LD_PRELOAD, ipex.cpu.runtime.CPUPool will also not be used anymore in the main code, otherwise it will cause an error that expect that env variable to exist. Please re-check that.

Yes, we don't need ipex.cpu.runtime neither. We can just set the core binding using numactl -m 0 -C cores to get the similar effect.

Absolutely. I'm just concerning that running the neuralchat service shell script will normally bind to one socket, which may be different cores than 24. But normally I believe it is slight performance difference.

@hshen14
Copy link
Contributor

hshen14 commented Sep 13, 2023

As we discussed, there might be no additional perf optimizations on HPU at this moment. Can you move forward this PR?

@hshen14 hshen14 merged commit fb619e5 into main Sep 13, 2023
@hshen14 hshen14 deleted the spycsh/habana_audio branch September 13, 2023 13:32
lvliang-intel pushed a commit that referenced this pull request Sep 13, 2023
* hpu asr support * add hpu support for tts * enhance device condition * fix lint and coverage * remove env variables * remove cpu_pool --------- Co-authored-by: Haihao Shen <haihao.shen@intel.com> Signed-off-by: Lv, Liang1 <liang1.lv@intel.com>
hshen14 added a commit that referenced this pull request Sep 14, 2023
* Support HPU on ASR/TTS (#290) * hpu asr support * add hpu support for tts * enhance device condition * fix lint and coverage * remove env variables * remove cpu_pool --------- Co-authored-by: Haihao Shen <haihao.shen@intel.com> Signed-off-by: Lv, Liang1 <liang1.lv@intel.com> * Merge finetuning and inference docker into unified one Signed-off-by: Lv, Liang1 <liang1.lv@intel.com> * update docker files Signed-off-by: Lv, Liang1 <liang1.lv@intel.com> * fix path issue Signed-off-by: Lv, Liang1 <liang1.lv@intel.com> --------- Signed-off-by: Lv, Liang1 <liang1.lv@intel.com> Co-authored-by: Spycsh <39623753+Spycsh@users.noreply.github.com> Co-authored-by: Haihao Shen <haihao.shen@intel.com> Co-authored-by: kevinintel <hanwen.chang@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

4 participants