Skip to content
This repository was archived by the owner on Oct 25, 2024. It is now read-only.

Conversation

@XuhuiRen
Copy link
Contributor

@XuhuiRen XuhuiRen commented Sep 1, 2023

Type of Change

Fix the code errors in rag example

Signed-off-by: XuhuiRen <xuhui.ren@intel.com>
Signed-off-by: XuhuiRen <xuhui.ren@intel.com>
Signed-off-by: XuhuiRen <xuhui.ren@intel.com>
Signed-off-by: XuhuiRen <xuhui.ren@intel.com>
Signed-off-by: XuhuiRen <xuhui.ren@intel.com>
@lvliang-intel
Copy link
Contributor

@XuhuiRen:Please fix the pylint issues.
[
{
"type": "error",
"module": "intel_extension_for_transformers.neural_chat.config",
"obj": "",
"line": 30,
"column": 0,
"path": "intel_extension_for_transformers/neural_chat/config.py",
"symbol": "no-name-in-module",
"message": "No name 'SparseBM25Retriever' in module 'intel_extension_for_transformers.neural_chat.pipeline.plugins.retrievals.retrieval'",
"message-id": "E0611"
},
{
"type": "error",
"module": "intel_extension_for_transformers.neural_chat.config",
"obj": "",
"line": 30,
"column": 0,
"path": "intel_extension_for_transformers/neural_chat/config.py",
"symbol": "no-name-in-module",
"message": "No name 'ChromaRetriever' in module 'intel_extension_for_transformers.neural_chat.pipeline.plugins.retrievals.retrieval'",
"message-id": "E0611"
},
{
"type": "error",
"module": "intel_extension_for_transformers.neural_chat.cli.cli_commands",
"obj": "",
"line": 23,
"column": 0,
"path": "intel_extension_for_transformers/neural_chat/cli/cli_commands.py",
"symbol": "no-name-in-module",
"message": "No name 'FinetuningConfig' in module 'intel_extension_for_transformers.neural_chat.config'",
"message-id": "E0611"
},
{
"type": "error",
"module": "intel_extension_for_transformers.neural_chat.pipeline.plugins.retrievals.indexing.document_parser",
"obj": "DocumentIndexing.KB_construct",
"line": 133,
"column": 30,
"path": "intel_extension_for_transformers/neural_chat/pipeline/plugins/retrievals/indexing/document_parser.py",
"symbol": "unexpected-keyword-arg",
"message": "Unexpected keyword argument 'metadata' in constructor call",
"message-id": "E1123"
}
]

@XuhuiRen
Copy link
Contributor Author

XuhuiRen commented Sep 2, 2023

@XuhuiRen:Please fix the pylint issues. [ { "type": "error", "module": "intel_extension_for_transformers.neural_chat.config", "obj": "", "line": 30, "column": 0, "path": "intel_extension_for_transformers/neural_chat/config.py", "symbol": "no-name-in-module", "message": "No name 'SparseBM25Retriever' in module 'intel_extension_for_transformers.neural_chat.pipeline.plugins.retrievals.retrieval'", "message-id": "E0611" }, { "type": "error", "module": "intel_extension_for_transformers.neural_chat.config", "obj": "", "line": 30, "column": 0, "path": "intel_extension_for_transformers/neural_chat/config.py", "symbol": "no-name-in-module", "message": "No name 'ChromaRetriever' in module 'intel_extension_for_transformers.neural_chat.pipeline.plugins.retrievals.retrieval'", "message-id": "E0611" }, { "type": "error", "module": "intel_extension_for_transformers.neural_chat.cli.cli_commands", "obj": "", "line": 23, "column": 0, "path": "intel_extension_for_transformers/neural_chat/cli/cli_commands.py", "symbol": "no-name-in-module", "message": "No name 'FinetuningConfig' in module 'intel_extension_for_transformers.neural_chat.config'", "message-id": "E0611" }, { "type": "error", "module": "intel_extension_for_transformers.neural_chat.pipeline.plugins.retrievals.indexing.document_parser", "obj": "DocumentIndexing.KB_construct", "line": 133, "column": 30, "path": "intel_extension_for_transformers/neural_chat/pipeline/plugins/retrievals/indexing/document_parser.py", "symbol": "unexpected-keyword-arg", "message": "Unexpected keyword argument 'metadata' in constructor call", "message-id": "E1123" } ]

@lvliang-intel E0611 is caused by xinyu's PR on yesterday but I did nothing change on the config.py. The other three issues are fixed

@hshen14
Copy link
Contributor

hshen14 commented Sep 4, 2023

@XinyuYe-Intel please take a look

@hshen14 hshen14 merged commit d2cee03 into main Sep 4, 2023
@hshen14 hshen14 deleted the rag_revision branch September 4, 2023 03:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants