Make key optional in ipex.llm.functional.rotary_embedding #821
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| format, also wondering how do we test here? |
Author
| @jingxu10 @ZailiWang could you take a look? |
Contributor
| cc @zhuyuhua-v |
| There is no CI in public repo. @jingxu10 @ZailiWang could you please cherry pick the PR and test it in internal repo? |
Contributor
OK, let me do it and feedback the result. |
Contributor
| Hi @sarckk , thanks a lot for the contribution as well as the notification of recent updates in vLLM, we are implementing some other updating requests for vLLM integration, and this PR, along with some other changes needed at the frontend, will be merged then. |
Author
| @ZailiWang sounds good! thanks for closing the loop on this |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Context: vLLM has a PR to make
keyarg in rotary embedding optional (vllm-project/vllm#17566). Currently, this is not supported inipex.llm.functional.rotary_embedding_batchedthat vLLM uses. I couldn't findrotary_embedding_batchedhere, so I'm assuming this is generated fromrotary_embedding.I wasn't able to build and test as I don't have access to intel cpu or xpu, looking for review/feedback. thanks
Note: this only modifies
ipex.llm.functional.rotary_embeddingAPI