Skip to content

Use sys.exit as there is no os.exit #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
huydhn wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use sys.exit as there is no os.exit #813

huydhn wants to merge 4 commits into from

Conversation

@huydhn
Copy link

@huydhn huydhn commented Apr 22, 2025 •
edited
Loading

I found this small bug when building vLLM with XPU support. According to Python doc https://docs.python.org/3.12/library/os.html, there is no os.exit. The correct call should be sys.exit. Here is the exception https://github.com/vllm-project/vllm/actions/runs/14605100087/job/40972245985#step:11:229

Also fix some minor lint warnings
huydhn added 4 commits April 22, 2025 14:49
@huydhn
Use sys.exit as there is no os.exit
5f76a18
@huydhn
Fix lint
14c1b6a 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Fix lint
98927b5 
Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn
Merge branch 'main' into fix-os-exit
5f77f65 
Signed-off-by: Huy Do <huydhn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@huydhn