This repository was archived by the owner on Jan 28, 2023. It is now read-only.
Improve CPUID module #470
Merged
Improve CPUID module #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Some CPUID instructions require the subleaf support. Enable the subleaf of CPUID instruction to expand the support of more features. * Add the subleaf into CPUID manager and cache the supported CPUID instructions with the subleaf enabling during the guest initialization * Add the subleaf into CPUID controller and support to set features by searching both leaf and subleaf * Adjust the algorithm of executing CPUID instruction and add the support of uncached CPUID values Signed-off-by: Wenchao Wang <wenchao.wang@intel.com>
Implement functions to check, set and clear the status of the x86 feature bit for the guest CPUID instruction. * Reversely parse the leaf, subleaf, register and bit values from the feature key * Implement the functions to check and update the feature status * Provide an internal interface to check whether the guest has a specific feature Signed-off-by: Wenchao Wang <wenchao.wang@intel.com>
Adjust the implementation for CPUID.07H, including caching host and guest values. * Add X86_FEATURE_ERMS definition for CPUID.(EAX=07H,ECX=0):EBX.ERMS[bit 9], which is the currently supported feature in CPUID.(EAX=07H, ECX=0) * CPUID.(EAX=07H, ECX=1) is not supported so far Signed-off-by: Wenchao Wang <wenchao.wang@intel.com>
hyuan3 approved these changes Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Improve the implementation of CPUID module