Skip to content
This repository was archived by the owner on Jan 28, 2023. It is now read-only.

Conversation

@wcwang
Copy link
Contributor

@wcwang wcwang commented Aug 14, 2020

Use the array of hax_cpuid_entry to store feature set. This approach is
helpful for the extension of more CPUID features support. It ensures
that the same data structure hax_cpuid_entry is used internally and
externally. When adding a new CPUID feature, it makes the implementation
easy by inserting an entry to the array of kCpuidSet.

Signed-off-by: Wenchao Wang wenchao.wang@intel.com

Use the array of hax_cpuid_entry to store feature set. This approach is helpful for the extension of more CPUID features support. It ensures that the same data structure hax_cpuid_entry is used internally and externally. When adding a new CPUID feature, it makes the implementation easy by inserting an entry to the array of kCpuidSet. Signed-off-by: Wenchao Wang <wenchao.wang@intel.com>
@wcwang wcwang requested a review from coxuintel August 14, 2020 08:27
@HaxmCI HaxmCI added CI:Build Pass CI:Build Pass CI:Mac Test Pass CI:Mac Test Pass labels Aug 14, 2020
Copy link
Contributor

@coxuintel coxuintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. With the change adding more CPUID will be friendly.

@wcwang wcwang merged commit 22dba85 into master Aug 14, 2020
@wcwang wcwang deleted the cpuid-opt branch August 14, 2020 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CI:Build Pass CI:Build Pass CI:Mac Test Pass CI:Mac Test Pass

4 participants