Skip to content

Conversation

@johnmccrae
Copy link
Contributor

Description

Chef Infra team is starting the work to incorporate inspec 7 into the builds. In updating things, we came across a version conflict where Inspec is using a much older version of Faraday that caused a version collision in Chef. Here we are updating Faraday in Inspec to match the Chef Infra version. I ran the "bundle exec rake:default" and did not note any local errors related to Faraday

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New content (non-breaking change)
  • Breaking change (a content change which would break existing functionality or processes)

Checklist:

  • I have read the CONTRIBUTING document.
Signed-off-by: John McCrae <mccrae@progress.com>
@johnmccrae johnmccrae requested a review from a team as a code owner January 29, 2025 23:55
@chef-expeditor
Copy link
Contributor

Hello johnmccrae! Thanks for the pull request!

Here is what will happen next:

  1. Your PR will be reviewed by the maintainers.
  2. Possible Outcomes
    a. If everything looks good, one of them will approve it, and your PR will be merged.
    b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner.
    c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

@Vasu1105 Vasu1105 merged commit d681e48 into inspec-7 Jan 30, 2025
8 checks passed
@Vasu1105 Vasu1105 deleted the jfm/inspec-faraday-update-inspec-7 branch January 30, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants