Add Typeable constraint to nextState #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was already satisfied in all call-sites, so this is a one-line change. For concrete tests, this constraint is not required because matching on the `Action` will reveal what `a` is, but it is necessary when defining polymorphic abstractions on top of `quickcheck-dynamic`.
| As far as I can tell this is a completely uncontroversial change - the |
MaximilianAlgehed approved these changes Sep 6, 2022
| Thank you kindly :) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This was already satisfied in all call-sites, so this is a one-line change. For concrete tests, this constraint is not required because matching on the
Actionwill reveal whatais, but it is necessary when defining polymorphic abstractions on top ofquickcheck-dynamic.Hopefully this is an uncontroversial change :) This is the minimum change I need to make the lockstep stuff work.