fix: avoid re-rendering on notification removal [LW-13712] #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
|
Allure Report
processReports: ✅ test report for 843f0bc6
|
mchappell reviewed Oct 17, 2025
| const history = useHistory(); | ||
| | ||
| const onBack = useCallback(() => { | ||
| history.goBack(); |
There was a problem hiding this comment.
what happens if this gets called from a bookmarked page?
vetalcore merged commit 946cfb9 into feat/lw-13591-subscriptions-dropdown 27 checks passed
vetalcore deleted the fix/lw-13712-avoid-rerendering-on-notification-removal branch vetalcore added a commit that referenced this pull request Oct 17, 2025
* feat: implement subscriptions list component * feat(extension): add id property to NotificationsTopic * feat: implement notification details component (#2018) * feat: render urls as links in notification details * refactor: change subscribe / unsubscribe type * fix: notification center ui fixes * fix: avoid unnecessary re-rendering on notification removal (#2022) --------- Co-authored-by: Mircea Hasegan <mircea.hasegan@iohk.io> Co-authored-by: Daniele Ricci <daniele.ricci@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Split all the container level components into the container and content.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots
Attach screenshots here if implementation involves some UI changes