Skip to content

Conversation

@Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Sep 15, 2025

Description

Updated the current catalyst-signed-doc integration tests. Provided more test cases and cleaned up the current implementation.

Related Issue(s)

Part of https://github.com/input-output-hk/catalyst-internal-docs/issues/266

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module
@Mr-Leshiy Mr-Leshiy moved this from New to 🏗 In progress in Catalyst Sep 15, 2025
@Mr-Leshiy Mr-Leshiy added squad: gatekeepers Catalyst App Backend, System Development & Integration Team draft Draft labels Sep 15, 2025
@Mr-Leshiy Mr-Leshiy marked this pull request as draft September 16, 2025 06:48
@Mr-Leshiy Mr-Leshiy force-pushed the feat/signed-doc-tests branch from 8fea671 to fb30d84 Compare September 17, 2025 08:51
@Mr-Leshiy Mr-Leshiy force-pushed the feat/signed-doc-tests branch from fb30d84 to aafdbc1 Compare September 17, 2025 09:03
@Mr-Leshiy Mr-Leshiy force-pushed the feat/signed-doc-tests branch from 450e052 to 07c9440 Compare September 19, 2025 11:59
@Mr-Leshiy Mr-Leshiy added review me PR is ready for review and removed draft Draft labels Sep 22, 2025
@Mr-Leshiy Mr-Leshiy moved this from 🏗 In progress to 👀 In review in Catalyst Sep 22, 2025
@Mr-Leshiy Mr-Leshiy requested review from apskhem and saibatizoku and removed request for apskhem September 22, 2025 05:33
@Mr-Leshiy Mr-Leshiy marked this pull request as ready for review September 22, 2025 05:35
@Mr-Leshiy Mr-Leshiy force-pushed the feat/signed-doc-tests branch from 72b3acd to ba85692 Compare September 22, 2025 06:35
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

Test Report | ${\color{lightgreen}Pass: 466/466}$ | ${\color{red}Fail: 0/466}$ |

@Mr-Leshiy Mr-Leshiy requested a review from apskhem September 23, 2025 10:44
apskhem
apskhem previously approved these changes Sep 23, 2025
Copy link
Collaborator

@apskhem apskhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mr-Leshiy Mr-Leshiy merged commit 92a937c into main Sep 23, 2025
20 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/signed-doc-tests branch September 23, 2025 11:05
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team

3 participants