Skip to content

Conversation

@no30bit
Copy link
Contributor

@no30bit no30bit commented Jul 15, 2025

Description

Bumps rust-ipfs in order to bump its dependencies.
Old dependencies cause advisers to issue security warnings.

@no30bit no30bit requested review from rafal-ch and stevenj July 15, 2025 10:28
@no30bit no30bit self-assigned this Jul 15, 2025
@no30bit no30bit added the dependencies Pull requests that update a dependencies label Jul 15, 2025
@no30bit no30bit added this to Catalyst Jul 15, 2025
@no30bit no30bit added the backend Task could/should be picked up as work on the backend. label Jul 15, 2025
stevenj
stevenj previously approved these changes Jul 15, 2025
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending updates to CI.

@no30bit no30bit force-pushed the chore/hermes-ipfs-bump branch from 433ee5d to 8e3d9c6 Compare July 17, 2025 13:14
@no30bit no30bit moved this from New to 🛑 Blocked in Catalyst Jul 18, 2025
@Mr-Leshiy
Copy link
Contributor

could we wait with this branch until this feature would be merged into the main #338, because as I see a new fmt rules are applied here, which could be quit complicated fix merge conflicts.

@no30bit no30bit moved this from 🛑 Blocked to 🏗 In progress in Catalyst Jul 25, 2025
@stevenj
Copy link
Collaborator

stevenj commented Jul 28, 2025

could we wait with this branch until this feature would be merged into the main #338, because as I see a new fmt rules are applied here, which could be quit complicated fix merge conflicts.

The hermes project needs this merged. Can we either do a single PR now to all cat-libs that only fixes format (and nothing else), as its been changed. OR revert the format changes so these PR's are not enormous?

CC: @Mr-Leshiy @rafal-ch

Its unreasonable to hold this back when it has nothing actually to do with #338

@rafal-ch
Copy link
Contributor

I agree we should revert the format changes, these should not be mixed together with the bumps. Working on it.

This reverts commit 52a726e.
@rafal-ch
Copy link
Contributor

Changes to catalyst-ci reverting the formatter configuration: input-output-hk/catalyst-ci#418

@github-actions
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 320/320}$ | ${\color{red}Fail: 0/320}$ |

@rafal-ch rafal-ch requested review from Mr-Leshiy and stevenj July 29, 2025 13:29
@stevenj stevenj merged commit 8b0b30f into main Jul 29, 2025
24 checks passed
@stevenj stevenj deleted the chore/hermes-ipfs-bump branch July 29, 2025 13:40
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Catalyst Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Task could/should be picked up as work on the backend. dependencies Pull requests that update a dependencies

5 participants