Correction for stability window constants #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The variables k and f for stability window had got nothing to do with Shelley reward parameters, the author may have confused `nOpt` which was commonly called `k` by some.
| 👷 Deploy request for cardano-documentation-staging pending review. 🔨 Explore the source changes: 4c735ac |
| thank you for your feedback, will confirm this with the team. |
brunjlar reviewed Nov 2, 2021
content/04-core-concepts/11-chain-confirmation-versus-transaction-confirmation.mdx Show resolved Hide resolved
brunjlar reviewed Nov 2, 2021
content/04-core-concepts/11-chain-confirmation-versus-transaction-confirmation.mdx Outdated Show resolved Hide resolved
nahern approved these changes Nov 2, 2021
nahern added a commit that referenced this pull request Nov 5, 2021
resolves this PR: Correction for stability window constants (#217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The variables
kandffor stability window have nothing to do with Shelley reward parameters, the author may have confusednOptwhich was commonly calledkby some.