Skip to content

Conversation

michaelahojna
Copy link
Contributor

@michaelahojna michaelahojna commented Oct 4, 2022

Proposed Changes

Adding possibility of accessing response data in List FluxRecord.getRow().

In case of using pivot on data, where field contains labels that occur by default in the annotated CSV (f.e. "result" or "table"), could be duplicated column names in response. In that case FluxRecord.getValues() (Map), which can hold only unique keys, doesn't show complete data. This edge case is solved by using FluxRecord.getRow() (List).

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • mvn test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍
There are a few requirements that must be be satisfy before we accept the PR:

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2022

Codecov Report

Base: 88.38% // Head: 88.39% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (4b374e7) compared to base (97cbf10).
Patch coverage: 90.90% of modified lines in pull request are covered.

❗ Current head 4b374e7 differs from pull request most recent head 3c6788b. Consider uploading reports for the commit 3c6788b to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@ ## master #439 +/- ## ============================================ + Coverage 88.38% 88.39% +0.01%  Complexity 776 776 ============================================ Files 172 172 Lines 6999 7008 +9 Branches 377 378 +1 ============================================ + Hits 6186 6195 +9  Misses 693 693 Partials 120 120 
Impacted Files Coverage Δ
...e/src/main/java/com/influxdb/query/FluxRecord.java 80.00% <66.66%> (+1.42%) ⬆️
...ava/com/influxdb/query/internal/FluxCsvParser.java 97.66% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bednar bednar marked this pull request as ready for review October 6, 2022 08:33
@michaelahojna michaelahojna requested a review from bednar October 6, 2022 09:54
Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌹

@bednar bednar merged commit ad018cd into master Oct 6, 2022
@bednar bednar deleted the record-row branch October 6, 2022 11:00
@bednar bednar added this to the 6.7.0 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants