Skip to content

Adding Talk Links—9 (4.0.4) #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 2, 2023
Merged

Adding Talk Links—9 (4.0.4) #238

merged 5 commits into from
Jun 2, 2023

Conversation

mazenchami
Copy link
Collaborator

Description

Now that the talks have been posted, we've updated the webflow-data.ts file to include talk-url for all available talks.

Version bump is also included here

Graphics

iOS Android


Checklist:

  • I have done a thorough self-review of my code
  • I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • I have run tests and linter
@mazenchami mazenchami requested a review from morganick June 2, 2023 13:58
@mazenchami mazenchami self-assigned this Jun 2, 2023
@mazenchami mazenchami marked this pull request as ready for review June 2, 2023 14:03
morganick
morganick suggested changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@morganick morganick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Android, the watch button is behind the software buttons:
Screenshot_20230602_101018_Chain React App 2023
@mazenchami
Copy link
Collaborator Author

On Android, the watch button is behind the software buttons: Screenshot_20230602_101018_Chain React App 2023

please pull latest. this commit solves it: 026e938
@mazenchami mazenchami requested a review from morganick June 2, 2023 14:16
morganick
morganick suggested changes Jun 2, 2023
View reviewed changes
@mazenchami mazenchami requested a review from morganick June 2, 2023 14:39
morganick
morganick approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@morganick morganick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@morganick
Copy link
Contributor

@mazenchami one thing I didn't check was the font size changes with the button 🤔
@morganick
Copy link
Contributor

@mazenchami never mind, button text size doesn't change based on font size changes to the phone.
@mazenchami
Copy link
Collaborator Author

@mazenchami one thing I didn't check was the font size changes with the button 🤔

we actually disable font scaling on this button
Screenshot 2023-06-02 at 10 50 51 AM
@mazenchami mazenchami merged commit 184f10b into main Jun 2, 2023
@mazenchami mazenchami deleted the talk-links branch June 2, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@mazenchami @morganick