FFT using pyvkfft and use loopy callables #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator Author
| @inducer, this is ready for another look |
inducer reviewed Jun 6, 2022
sumpy/fmm.py Outdated
Comment on lines 809 to 811
| evt_fft = self.run_opencl_fft(queue, | ||
| preprocessed_source_mpoles_view, | ||
| inverse=False, wait_for=wait_for) |
Owner
There was a problem hiding this comment.
Convert to out-of-place to be nice to our future, lazy-eval selves?
sumpy/fmm.py Outdated
Comment on lines 809 to 811
| evt_fft = self.run_opencl_fft(queue, | ||
| preprocessed_source_mpoles_view, | ||
| inverse=False, wait_for=wait_for) |
Owner
There was a problem hiding this comment.
Suggested change
| evt_fft = self.run_opencl_fft(queue, | |
| preprocessed_source_mpoles_view, | |
| inverse=False, wait_for=wait_for) | |
| preprocessed_source_mpoles_view, evt_fft = self.run_opencl_fft(queue, | |
| preprocessed_source_mpoles_view, | |
| inverse=False, wait_for=wait_for) |
sumpy/fmm.py Outdated
Comment on lines 546 to 547
| def get_opencl_fft_app(self, queue, shape, dtype): | ||
| return get_opencl_fft_app(queue, shape, dtype) |
Owner
There was a problem hiding this comment.
Suggested change
| def get_opencl_fft_app(self, queue, shape, dtype): | |
| return get_opencl_fft_app(queue, shape, dtype) | |
| def get_opencl_fft_app(self, shape, dtype): | |
| with cl.CommandQueue(self.cl_context) as queue: | |
| return get_opencl_fft_app(queue, shape, dtype) |
inducer reviewed Jun 6, 2022
Collaborator Author
| Using the private API from pyvkfft, this passes. |
Owner
| Ready for review from your perspective? Or should we wait? |
Collaborator Author
| Ready for review |
inducer reviewed Jun 25, 2022
inducer reviewed Jun 27, 2022
sumpy/fmm.py Outdated
Comment on lines 556 to 558
| def run_opencl_fft(self, queue, input_vec, inverse, wait_for, inplace): | ||
| app = self.tree_indep.opencl_fft_app(input_vec.shape, input_vec.dtype, | ||
| inplace) |
inducer approved these changes Jun 27, 2022
Owner
inducer left a comment
inducer left a comment There was a problem hiding this comment.
🎉 LGTM (after inplace is gone)
Owner
| Thanks! |
This was referenced Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
- [ ] Needs Allow separate queue for fft and ifft vincefn/pyvkfft#17 and patch the conda package