- Notifications
You must be signed in to change notification settings - Fork 15
Closed
Description
At this point (and continuing with #95), we have tons of different recipes for doing translations, particularly M2Ls. I think those should be objects in their own right (to simplify dispatch to code generation), instead of harboring if/then/else "which mode" soup in the methods of the expansion. These methods are a good example of holding the target expansion responsible for knowing more than it should about the translation:
sumpy/sumpy/expansion/local.py
Lines 55 to 60 in 7aa3dd8
| .. automethod:: m2l_translation_classes_dependent_data | |
| .. automethod:: m2l_translation_classes_dependent_ndata | |
| .. automethod:: m2l_preprocess_multipole_exprs | |
| .. automethod:: m2l_preprocess_multipole_nexprs | |
| .. automethod:: m2l_postprocess_local_exprs | |
| .. automethod:: m2l_postprocess_local_nexprs |
cc @isuruf
isuruf
Metadata
Metadata
Assignees
Labels
No labels