Add map and set extract_if #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cuviper added the waiting-for-std 
cuviper commented Feb 3, 2024
src/map/core/raw.rs Outdated
| | ||
| if new_len != old_len { | ||
| // We don't keep track of *which* items were extracted, so reindex everything. | ||
| self.map.rebuild_hash_table(); |
There was a problem hiding this comment.
While it would be nice to reuse vec::ExtractIf, I haven't found a way to do this fixup for the indices afterward, because that vec::ExtractIf would be holding &mut on the entries, excluding even a raw pointer elsewhere.
cuviper removed the waiting-for-std Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.