Skip to content

Conversation

@Duartegdm
Copy link
Contributor

Pull Request Template

What does this PR do?

This PR improves the documentation of the pattern "anti-corruption-layer".

On this PR, I changed the attribute orderInModernSystem type from Optional to Optional. Improving the usage example on README.MD.

@github-actions
Copy link

github-actions bot commented Mar 14, 2025

PR Summary

Improved the documentation of the anti-corruption-layer pattern by changing the orderInModernSystem attribute type from Optional<LegacyOrder> to Optional<ModernOrder> and enhancing the usage example in the README.md file.

Changes

File Summary
anti-corruption-layer/README.md Updated the example in the anti-corruption-layer documentation by changing the type of the orderInModernSystem variable from Optional<LegacyOrder> to Optional<ModernOrder>. This change improves the clarity and accuracy of the example.

autogenerated by presubmit.ai

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (1)
  • 3f65efd: docs: Improve Anti-Corruption-Layer README(#3200)
Files Processed (1)
  • anti-corruption-layer/README.md (1 hunk)
Actionable Comments (1)
  • anti-corruption-layer/README.md [125-125]

    possible issue: "Type Change in orderInModernSystem"

Skipped Comments (0)
String id = legacyOrder.getId();

Optional<LegacyOrder> orderInModernSystem = acl.findOrderInModernSystem(id);
Optional<ModernOrder> orderInModernSystem = acl.findOrderInModernSystem(id);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type of orderInModernSystem has changed from Optional<LegacyOrder> to Optional<ModernOrder>. Ensure this change is consistent with the overall design and doesn't introduce unexpected behavior or break existing functionality.

@iluwatar iluwatar merged commit a89cf98 into iluwatar:master Mar 18, 2025
2 checks passed
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @Duartegdm for docs

@allcontributors
Copy link
Contributor

@iluwatar

I've put up a pull request to add @Duartegdm! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants