Issue#1264: Implemented Composite-View Pattern #1923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…d private fields. Created test file for JavaBeans.
…o composite-view to allow the JSP to run on a local Tomcat container. Wrote unit tests for Java-bean class, working on JSP pages.
…reated atomic sub-view components in businessNews.jsp, header.jsp, localNews.jsp, scienceNews.jsp, sportsNews.jsp, worldNews.jsp. Composite view page renders correctly, atomic views are inserted in and substituted in the template page depending on request parameters.
…ed to .equals() for string comparison.
…ensure writers are closed.
iluwatar requested changes Dec 11, 2021
composite-view/src/main/java/com/iluwatar/compositeview/ClientPropertiesBean.java Outdated Show resolved Hide resolved
composite-view/src/test/java/com/illuwatar/compositeview/JavaBeansTest.java Outdated Show resolved Hide resolved
Owner
| In addition, SonarCloud code analysis is failing due to insufficient test coverage. Try to add more tests. |
Contributor Author
| for the code coverage, I'm not sure what tools/libraries there are to unit test HTTP servlets, do you have any suggestions? |
tedyoung reviewed Dec 11, 2021
composite-view/src/test/java/com/illuwatar/compositeview/JavaBeansTest.java Show resolved Hide resolved
… to reduce boilerplate setters and getter, updated README.md with better grammar, appropriate tags and links to related patterns. Updated pom.xml to get rid of superfluous lines.
iluwatar requested changes Dec 23, 2021
composite-view/README.md Outdated
| title: Composite View | ||
| folder: composite-view | ||
| permalink: /patterns/composite-view/ | ||
| categories: structural |
Owner
There was a problem hiding this comment.
Suggested change
| categories: structural | |
| categories: Structural |
composite-view/README.md Outdated
| * Increases potential for display errors | ||
| | ||
| ## Related patterns | ||
| * [Composite (GoF)](../composite) |
Owner
There was a problem hiding this comment.
I suggest linking to the website https://java-design-patterns.com/patterns/composite/
Contributor Author
There was a problem hiding this comment.
apologies, I was busy for the holidays, I have added these changes in my latest commit.
iluwatar approved these changes Jan 18, 2022
Owner
| Excellent, thank you for adding this pattern! |
Contributor
| I've put up a pull request to add @Kevinyl3! 🎉 |
| Kudos, SonarCloud Quality Gate passed! |
RobbiNespu pushed a commit to RobbiNespu/java-design-patterns that referenced this pull request Mar 1, 2022
…#1923) * initial commit, created package, README, pom, and directory structure. * Issue#1264, continue working on JavaBeans, added getters, setters, and private fields. Created test file for JavaBeans. * set up junit for tests folder. * Issue#1264, set up local server and added web-application framework to composite-view to allow the JSP to run on a local Tomcat container. Wrote unit tests for Java-bean class, working on JSP pages. * Issue#1264, Added forwarding functionality to servlet and main composite view page. * Issue#1264, Finished composite view template in newsDisplay.jsp and created atomic sub-view components in businessNews.jsp, header.jsp, localNews.jsp, scienceNews.jsp, sportsNews.jsp, worldNews.jsp. Composite view page renders correctly, atomic views are inserted in and substituted in the template page depending on request parameters. * Issue#1264, Added all views, updated README.md with documentation. * Issue#1264, updated README.md, moved images folder into etc folder. * Issue#1264, removed build artifacts from tracked files. * Issue#1264, updated README.md * Issue#1264, updated README.md * Issue#1264, removed unused import, made AppServlet class final, changed to .equals() for string comparison. * Issue#1264, in AppServlet, put the output writing into try blocks to ensure writers are closed. * Issue#1264, added tests for Servlet, coverage up to 100%, used lombok to reduce boilerplate setters and getter, updated README.md with better grammar, appropriate tags and links to related patterns. Updated pom.xml to get rid of superfluous lines. * Issue#1264, made changes as requested in README.md. Co-authored-by: Ilkka Seppälä <iluwatar@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue#1264: Composite-View Pattern
Pull request description
composite-viewdirectory/module for the patternsrc\maincontains the javabean class for view management, and the Servlet classsrc\testcontains the tests for the methods in the javabean classwebcontains the all the JSP files and the web.xml file